test_that("boolean_arithmetic_linter doesn't block allowed usages", { linter <- boolean_arithmetic_linter() expect_lint("!any(x == y)", NULL, linter) expect_lint("!any(grepl(pattern, x))", NULL, linter) }) test_that("boolean_arithmetic_linter requires use of any() or !any()", { linter <- boolean_arithmetic_linter() lint_msg <- rex::rex("Use any() to express logical aggregations.") expect_lint("length(which(x == y)) == 0", lint_msg, linter) # anything passed to which() can be assumed to be logical expect_lint("length(which(is_treatment)) == 0L", lint_msg, linter) # regex version expect_lint("length(grep(pattern, x)) == 0", lint_msg, linter) # sum version expect_lint("sum(x == y) == 0L", lint_msg, linter) expect_lint("sum(grepl(pattern, x)) == 0", lint_msg, linter) # non-== comparisons expect_lint("length(which(x == y)) > 0L", lint_msg, linter) expect_lint("length(which(is_treatment)) < 1", lint_msg, linter) expect_lint("length(grep(pattern, x)) >= 1L", lint_msg, linter) expect_lint("sum(x == y) != 0", lint_msg, linter) expect_lint("sum(grepl(pattern, x)) > 0L", lint_msg, linter) })